Closed lf94 closed 2 months ago
nice lgtm merge when ready and green
Attention: Patch coverage is 97.90210%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 77.74%. Comparing base (
78aac10
) to head (cdc5ef5
). Report is 6 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/types.rs | 0.00% | 2 Missing :warning: |
src/cmd_config.rs | 98.83% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When trying to set a default host through the command line, the CLI would report that
default
is an invalid key. This is because it was not part of the set ofConfigOption
's. The problem with just adding it to there, which I did at first just to see something working, is that these options are also meant to be top-level options. I had to redesign the program a little bit to understand the notion of host-level options and top-level options that can also be host-level options.A test is added to ensure that only one host can ever be set as
default
.