search

KittyCAD / diff-viewer-extension

View changes to your models directly within GitHub with our extension for all Chrome, Edge, and Chromium-powered browsers.
https://chrome.google.com/webstore/detail/kittycad-diff-viewer/gccpihmphokfjpohkmkbimnhhnlpmegp
29 stars 1 forks source link

Migration to three r155+ #538

Closed pierremtb closed 9 months ago

pierremtb commented 9 months ago

Fixes #497

As outlined in https://discourse.threejs.org/t/updates-to-lighting-in-three-js-r155/53733/24, multiplying the existing intensity values in SpotLight by Math.PI, add adding the non-physically-correct decay = 0 got us back to the same lighting conditions as before.

pierremtb commented 9 months ago

@Irev-Dev @franknoirot for viz if you need that migration done as well on the website stuff