search

KittyCAD / kcl-samples

KCL sample files
7 stars 0 forks source link

Pipes with bend radii #91

Open r-barton opened 1 month ago

r-barton commented 1 month ago

This is a sample which creates a parameterized pipe bend. However the interior hole is not being respected when revolving the sketch.

See this issue

r-barton commented 1 month ago

This is also related to a discord discussion see this thread

r-barton commented 1 month ago

@jgomez720 @greg-kcio opinions on merging this without a proper hole through the pipe

greg-kcio commented 1 month ago

@jgomez720 @greg-kcio opinions on merging this without a proper hole through the pipe

The code is clean but I think we should wait to include it until it produces a proper pipe with hole.

jgomez720 commented 1 month ago

Agree with Greg. Someone could export a STEP of this and use shell to create the official pipe, but we are asking for too much on the users end imo