search

KittyCAD / machine-api

This API intends to provide a standardized local interface to any machines used for manufacturing physical things.
17 stars 3 forks source link

start to hack in a 'hook' function #102

Closed paultag closed 1 month ago

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 13.33333% with 52 lines in your changes missing coverage. Please review.

Project coverage is 24.30%. Comparing base (093ad1d) to head (9caad23). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/server/endpoints.rs 0.00% 36 Missing :warning:
src/bin/machine-api/cmd_serve.rs 0.00% 8 Missing :warning:
src/server/mod.rs 50.00% 6 Missing :warning:
src/bin/machine-api/config/mod.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ========================================== - Coverage 24.34% 24.30% -0.05% ========================================== Files 46 46 Lines 2460 2489 +29 ========================================== + Hits 599 605 +6 - Misses 1861 1884 +23 ``` | [Flag](https://app.codecov.io/gh/KittyCAD/machine-api/pull/102/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/KittyCAD/machine-api/pull/102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | `24.30% <13.33%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paultag commented 1 month ago

going to need to refactor this a bit harder when i get cycles for this again, will close in the meantime, but it seems like this as a general thing may be welcome!