KittyCAD / machine-api

This API intends to provide a standardized local interface to any machines used for manufacturing physical things.
17 stars 3 forks source link

fix otel crate api breakage #186

Closed paultag closed 1 week ago

paultag commented 1 week ago

I'm not convinced the otel stuff is right, the API here changed a ton between 0.26 and 0.27. I'm going to read more carefully but this was what I could infer off READMEs.

There's no upgrading guide.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 24.63%. Comparing base (0ead022) to head (8d3b132). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/machine-api/main.rs 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #186 +/- ## ========================================== + Coverage 24.60% 24.63% +0.02% ========================================== Files 51 51 Lines 3280 3272 -8 ========================================== - Hits 807 806 -1 + Misses 2473 2466 -7 ``` | [Flag](https://app.codecov.io/gh/KittyCAD/machine-api/pull/186/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/KittyCAD/machine-api/pull/186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | `24.63% <16.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.