search

KittyCAD / machine-api

This API intends to provide a standardized local interface to any machines used for manufacturing physical things.
17 stars 3 forks source link

.... I think this is wrong and leaking to a leak #96

Closed paultag closed 2 months ago

paultag commented 2 months ago

needs a test -- thanks to @jessfraz for the report

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 25.69%. Comparing base (4c876cf) to head (4f19f83). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/bambu/discover.rs 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #96 +/- ## ========================================== - Coverage 25.70% 25.69% -0.02% ========================================== Files 46 46 Lines 2474 2475 +1 ========================================== Hits 636 636 - Misses 1838 1839 +1 ``` | [Flag](https://app.codecov.io/gh/KittyCAD/machine-api/pull/96/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/KittyCAD/machine-api/pull/96/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | `25.69% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.