Closed Irev-Dev closed 5 months ago
Yea, 3 is best here also because some other formats like obj can reference other files too within it. It's nice if 2 or more export files default to zip, otherwise their original format.
@lf94 is resolving this issue/ziping gltf-standard something you would be interested in doing?
Consider me interested :)
Awesome!
Note: changing this will break the exports of each format should work
e2e test, shouldn't be too hard to fix up and we can cross that bridge when we get to it.
But there's a whole
if (output.type === 'gltf' && output.storage === 'standard') {
// wait for second download
that will need to be removed.
Thanks for the heads-up!
This'll require a change somewhere on the server side to return a zip when appropriate.
No we want to handle it client side after we get the response.
Oh ok - I initially thought about doing it that way, but quickly I could see every single client needs to then implement or include a zip package in order to offer the same functionality which doesn't seem great.
Are we concerned about returning a zip from the server too resource intensive or adding a complication over there?
We already use this endpoint as is in the diff viewer and cli and in text to cad ui, changing the whole endpoint just for modeling app makes no sense then all those apps would have to unzip to keep the same functionality
I’m concerned about breaking people
Gotchya gotchya. :slightly_smiling_face: Thanks for filling me in! I think it would make sense but it's a good argument to not create unnecessary toil at this stage :laughing: (or break people :upside_down_face: )
https://github.com/KittyCAD/modeling-app/assets/29681384/0feb40f9-2209-4cb2-8286-c02b8d53f32c
like I said above fix is awaiting a promise so the pickers open up one after the other, but I'm not 100% sure about this, Rolling with it because it's better than before but
buffers [ {uri: "output.bin"}]
so if we let the user name the bin file something else it will likely break.Fixes are
I think 3 is the best