Clean up circular import dependencies

KittyCAD / modeling-app

The KittyCAD modeling app.

https://kittycad.io/modeling-app/download

MIT License

373 stars 31 forks source link

Clean up circular import dependencies #1203

Closed franknoirot closed 3 months ago

franknoirot commented 10 months ago

I read here that one of the reasons that hot module reloading isn't working reliably could be because of circular dependencies between React components. I installed this VS Code extension to check it out and sure enough there are a lot of circular dependencies in the app.

It'd be some pleasant work to clean them up, and I think there might be some larger benefits than just HMR working more nicely if we ensure there are none.

jessfraz commented 3 months ago

are we good here?

franknoirot commented 3 months ago

Yes, @Irev-Dev's work on singletons in https://github.com/KittyCAD/modeling-app/pull/1863