Show unavailable/disabled commands when searching in command palette

KittyCAD / modeling-app

The KittyCAD modeling app.

https://kittycad.io/modeling-app/download

MIT License

361 stars 29 forks source link

Show unavailable/disabled commands when searching in command palette #1541

Open franknoirot opened 6 months ago

franknoirot commented 6 months ago

Often users are just trying to see if a command is possible in the app when they search (such as Arc), and are not expecting to be able to perform the command.

I think we can safely include all possible commands, not just those who guards are satisfied, when a user searches explicitly. If possible, we might even be able to provide a reason it's unavailable or how the user cam get to a state where it would be available (although that's starting to sound like a graph traversal)

Irev-Dev commented 6 months ago

Perfect, I like this.

franknoirot commented 6 months ago

I'll likely do this, but in case someone gets to it before me, here are some steps:

Adjust the useStateMachineCommands hook to not filter by the .can() method of the state machine if the command bar has a search value (or, once implemented, whenever "everything bagel" command bar mode is activated
- Still should pass the fact that the command is unreachable to the command bar
Add logic to the CommandComboBox to support showing unreachable commands as disabled options