search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
362 stars 29 forks source link

Restore "Add ping pong health" #1770

Open franknoirot opened 6 months ago

franknoirot commented 6 months ago

Commit SHA: 61d7950ca37ed6eb59dade1161324f4c4c847d98

Restore this feature by fixing the remaining issues found with it in the desktop Tauri app, which result in a consistent "Stream disconnected" state after navigating from any project to home.

jessfraz commented 5 months ago

why not just hide the health thing on the home screen?

jessfraz commented 5 months ago

seems like the easiest fix

franknoirot commented 5 months ago

Yeah it is from the appearance side, and when we restore this we should just remove the NetworkHealthIndicator from the AppHeader to avoid that issue. But the more functional issue is that after that first navigation back to home, the stream was showing a "Stream disconnected" message with a loading spinner whenever you would navigate back into a project, which would stay there and was only recoverable by refreshing the page.