KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
373 stars 31 forks source link

Update overlay hover popovers #2390

Open Irev-Dev opened 4 months ago

Irev-Dev commented 4 months ago

When hovering on the overlays users see this:

image

But designs have since been updated eg:

image

See all designs here

jessfraz commented 4 months ago

is it weird i kinda like the first one better?

hard to put into words maybe its the font sizing or something

Irev-Dev commented 4 months ago

Oh CC @franknoirot

I know you said "hard to put into words" so I'm guessing you just mean the vibe of it and I guess the composure?

One of the things I liked about Frank's design (second one) is he's able to emphasise "Unconstrained", without it being the first thing in the popover.

jessfraz commented 4 months ago

yes I like that i think something about the font size, i cant really describe, just feels different

franknoirot commented 4 months ago

Maybe it feels a little top-heavy because there's a bunch of big text relative to how much smaller text there is. And I think the container could be feeling a bit cramped. Here's what I tweaked in this version:

  1. Remove the "[Function Name] ·" prefix, because it adds a lot of that larger font size. I'll have a think about how to communicate what line function is being used.
  2. moved the Constrained/Unconstrained tag up to the top, bumped down its padding. I think it sharing a row with that description text feels a little more cramped too.
  3. Double the padding around the whole card

Light mode, dark popover

Dark mode, light popover

Irev-Dev commented 4 months ago

This feels less cramped.

In regards to 1. we are still highlighting in the editor

2024-05-21 14 45 25

But is the thinking about when the editor is closed?

jessfraz commented 4 months ago

ooo i like those better