printlns in the parser/tokenizer/executor/lsp breaks kcl-lsp since it communicates over stdin/stdout, some sort of test to ensure we dont have any

KittyCAD / modeling-app

The KittyCAD modeling app.

https://kittycad.io/modeling-app/download

MIT License

412 stars 35 forks source link

printlns in the parser/tokenizer/executor/lsp breaks kcl-lsp since it communicates over stdin/stdout, some sort of test to ensure we dont have any #2468

Closed jessfraz closed 4 months ago

jessfraz commented 5 months ago

opening issue as a reminder as a part of https://github.com/KittyCAD/modeling-app/pull/2467 where i had to clean some up

jessfraz commented 5 months ago

cc @adamchalmers for ideas

adamchalmers commented 5 months ago

https://stackoverflow.com/questions/63302814/is-there-a-way-to-disable-enable-the-println-macro

jessfraz commented 5 months ago

hoily shizzzz so if i do that in the kcl-lsp repo, the one that wrapss kcl-lib will it apply or do i need to add to kcl-lib w feature flag, also i 100% knew youd know a way to do this