search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
273 stars 19 forks source link

[BUG]: Desktop app shows bad network until a project is opened #2610

Open franknoirot opened 3 weeks ago

franknoirot commented 3 weeks ago

Describe the bug

Presumably because the engine connection is not initialized until the first project is opened, the network health indicator shows a nebulous problem state until the user enters their first file. We will want tauri tests for this eventually.

Some solutions in my order of preference:

  1. Connect to the engine on app start up. I think this would have the knock-on effect of making first project load faster too.
  2. Make the network health indicator only check the validity of network connected status until the engine connection is attempted.
  3. Hide the network connection on home page

Steps to Reproduce

  1. Open the desktop app

Expected Behavior

The network health indicator should only show a problem if there is a problem the user needs to address or that is otherwise interfering with app use.

Screenshots and Recordings

Screenshot 2024-06-05 at 1 19 43 PM

Desktop OS

Any

Browser

None (desktop version only)

Version

v0.22.0

Additional Context

@jessfraz this one might be borderline not high-priority: it's high visibility but low user impact.

lf94 commented 3 weeks ago

The '-' actually means no connection yet - I think you could actually fix this quite easily looking in NetworkHealthIndicator (add a new state called 'Not started' and make it grey I guess). But yeah the alternative is starting engine immediately, which is probably best TBH. If the user forgets and never presses anything, our soon-to-be idle logic will kick in and kill the engine.

Edit: additionally I'm not able to test this in our desktop app because Linux

I'm currently working through ~350 type errors for the "throwing in frontend" issue, so, it will be awhile until I get to this issue.