KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
432 stars 37 forks source link

Grid continues to jump and disorient #2668

Closed lf94 closed 4 months ago

lf94 commented 5 months ago

We need to remove the grid I think, and re-evaluate how it's used. Right now it is too confusing.

lf94 commented 5 months ago

Related https://github.com/KittyCAD/modeling-app/issues/2039

lf94 commented 5 months ago

It's been decided, we are removing the grid.

nicboone8 commented 4 months ago

The jumpiness of the grid can be avoided by just running the gridlines off the ends of the viewer in every direction. Zooming in and out could reveal finer and finer minor grid lines within each square so that the coarseness of the grid is always appropriate for whatever scale you're working in grid concept

nicboone8 commented 4 months ago

(my gif isn't very smooth. The squares-within-a-square should probably also gain or lose transparency as you zoom in/away)

nicboone8 commented 4 months ago

This would also make it a lot easier to distinguish up from down if the user has spun the camera around a lot

nicboone8 commented 4 months ago

The scale indicator could live in the bottom right corner of the screen with the units indicator, rather than move around with the grid image

lf94 commented 4 months ago

Sorry if you're still seeing the grid the intent was to be off by default :)

jessfraz commented 4 months ago

he likes the grid :)

lf94 commented 4 months ago

Ah ok, grid is back on :)

This involves 2 engine changes and 1 modeling-app change:

  1. We need engine to do the new drawing logic

  2. We need engine to report scale changes as some event

  3. We need modeling-app to use these events to display the current scale

I'll open the issues when I get around to it, I may even try to do it myself

jessfraz commented 4 months ago

actually it turns out he just wanted something on empty scene, I pointed him to https://github.com/KittyCAD/modeling-app/issues/2880 @nicboone8 let us know if you'd still even use the grid with that, if not, we can close :)

lf94 commented 4 months ago

Oh much easier then

nicboone8 commented 4 months ago

yea, disabling the primary grid makes sense to me in that case. The sketch grid is still pretty useful