KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
426 stars 37 forks source link

Constraints are disabled #2696

Open ZooSpiritWolf opened 5 months ago

ZooSpiritWolf commented 5 months ago

🐛 on Dev

Steps to reproduce:

  1. Login
  2. Clear editor to clear sketch
  3. Start a new sketch
  4. Select a plane to start sketch
  5. Sketch a single or multiple segments
  6. Highlight the segments
  7. Deselect the tool to display the constraint dropdown menu
  8. Click the dropdown menu
  9. Observe constraint options Expected: Appropriate constraint options to be enabled and available Actual: Constraints that should be enabled are disabled

Timestamp: 0:14 Video: https://www.loom.com/share/b6235c54915b4512b5b95168520ac832?sid=614fad0a-2c06-420a-80d7-e5ddf8240b94 (https://www.loom.com/share/b6235c54915b4512b5b95168520ac832?sid=614fad0a-2c06-420a-80d7-e5ddf8240b94)

Bug report: https://app.qawolf.com/zoo/bug-reports/4953a484-77d2-4cd8-91d1-f4bd5a50342f

Affected workflows: • Multi-Select Lines - https://app.qawolf.com/zoo/workflows/clwfyn8ma0nvnzn90ea7hzkr0 • Vertical Constraint - Single Segment - https://app.qawolf.com/zoo/workflows/clwgjeysk0eigerw32i9ns64l • Vertical Constraint - Multiple Segments - https://app.qawolf.com/zoo/workflows/clwgjez3b07azi92vsec9b7s4 • Horizontal Constraint - Single Segment - https://app.qawolf.com/zoo/workflows/clwgjezdn0ejeerw31na1cd53 • Horizontal Constraint - Multiple Segments - https://app.qawolf.com/zoo/workflows/clwgjezn207bbi92v1pco6k7j

If you are aware of this bug you can set the priority to low which will prevent it from causing a run failure.

Irev-Dev commented 4 months ago

@jtran and I have made a start on this one.

jtran commented 4 months ago

The steps to reproduce in the issue were missing steps to reliably reproduce the problem.

  1. Create a sketch of two or more lines.
  2. Get out of drawing mode by clicking the line tool or pressing Escape. (Don't Exit Sketch though.)
  3. Edit the code of the coordinate in the first line to have many characters. E.g. change 1.3 to 1.333333. This ensures that the source range will change in the next step.
  4. Drag the first line segment (this invalidates the source ranges in the code)
  5. Holding Shift, click multiple line segments to select them

At this point, we expect items in the Constraints menu to be enabled, but they're not.