KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
282 stars 20 forks source link

Prevent mousewheel events while dragging for orbit/pan/zoom #2699

Open franknoirot opened 2 weeks ago

franknoirot commented 2 weeks ago

In some mouse control configurations (possibly only "Solidworks") users can incidentally move their mouse wheel (zoom) while middle-click-dragging (orbit). This leads to competing unreliable and reliable channel messages being sent to the engine to move the camera, resulting in sporadic behavior like this, where the camera jumps back to the position it was in when the mouse wheel moved:

https://github.com/KittyCAD/modeling-app/assets/23481541/33324464-a5ef-47a3-b67e-cec1e4ba534b

A better long term fix is to allow these competing commands to resolve nicely so that zooms, pans, and orbits can be done simultaneously. This will be especially important for space mouse users. But a fix for the current degraded experience for Solidworks mouse control users is to disallow mousewheel events while dragging.

dshaw commented 2 weeks ago

For reference there was a previous issue with the Solidworks settings which we were unable to reproduce or get further feedback on: https://github.com/KittyCAD/modeling-app/issues/1911

r-barton commented 1 week ago

Just want to add to this, I'm still having this issue even after switching to KittyCAD controls