search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
282 stars 20 forks source link

Embed connection stall reason in "Loading" div element for traceability of Playwright stalls #2724

Open franknoirot opened 2 weeks ago

franknoirot commented 2 weeks ago

Might be worth surfacing more clearly to users in the future, but one thing that @iterion raised when I asked about potential engine issues with our CI Playwright tests is that we have no insight to what backend issue is causing each of these "loading stalled" tests, because they appear in our logs as simple errors like this:

locator resolved to visible <div data-testid="loading" class="body-bg flex flex-c…>…</div>

But if we included a reason in that div as a data-* attribute it would be easier to correlate with what went wrong.

Irev-Dev commented 1 week ago

Nice! specifically what information do we put in here, we could just JSON dump all of the network state data?

jessfraz commented 2 days ago

Engine returns nice errors like too many connections we should just surface those like to the user as well