KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
368 stars 30 forks source link

[BUG]: helix() does not work on cylinders with a hole #2774

Closed dcl closed 2 months ago

dcl commented 3 months ago

Describe the bug

Intuitively one might begin to describe a threaded pipe with the following KCL:

let threadedPipe = startSketchOn("XY")
    |> circle([0, 0], 5, %)
    |> hole(circle([0, 0], 4, %), %)
    |> extrude(20, %)
    |> helix({angle_start: 0, length: 10, revolutions: 10}, %)

This results in an error, with helix() being unable to recognize the extrude as a valid cylinder: ss (2024-06-24 at 03 48 25)

Steps to Reproduce

  1. Copy the above KCL into the app

Expected Behavior

helix() would recognize a valid cylinder based on the exterior surface of the extrude group

Screenshots and Recordings

No response

Desktop OS

Windows 10

Browser

No response

Version

0.22.6

Additional Context

No response

jessfraz commented 2 months ago

unsure if this is an engine bug or not but @gserena01 might know

gserena01 commented 2 months ago

It's an engine bug! I'm on it!