KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
411 stars 35 forks source link

Spammed with toast error messages #2775

Open Irev-Dev opened 4 months ago

Irev-Dev commented 4 months ago

Almost certainly related to #2654 basically un some conditions a lot of errors come through and so I think this is a bit of a two-parter

image

It's hard to replicate exactly, I'll update the issue if I'm able to do it consistently, but here's vid of me doing it on https://app.zoo.dev/file/%2Fbrowser%2Fmain.kcl

https://github.com/KittyCAD/modeling-app/assets/29681384/31c8460d-9bea-4ee7-b8d3-71cf27bc9dc0

Because of how jarring this is, I think it needs to be fixed before next release.

lf94 commented 4 months ago

Yea this should be very easy to track and then suppress the trap if we want to simply not handle the error.

lf94 commented 4 months ago

No, you are right, we need to do:

Maybe we should defer the toast message and group errors together, because this many toasts is janky, this will be fix for any new instances of error spam

When the same toast message is about to be shown, we should aggregate them!

lf94 commented 4 months ago

Perfect:

out

lf94 commented 4 months ago

https://github.com/KittyCAD/modeling-app/pull/2801 will resolve

Irev-Dev commented 4 months ago

I'm going to open this issue again, because I would like to dig into the specific error and why it's being triggered at all, but I've removed the high priority tag at least.

jessfraz commented 4 months ago

at the same time can we look at the "not an object" errors in the console because thats super spammy too