search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
366 stars 29 forks source link

tags are globals #2795

Closed jessfraz closed 3 months ago

qa-wolf[bot] commented 3 months ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jun 25, 2024 5:16pm
jessfraz commented 3 months ago

the snapshots are from lees nuke the grid PR :)

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.38%. Comparing base (da6cd5c) to head (b1582eb). Report is 2 commits behind head on main.

Files Patch % Lines
src/wasm-lib/kcl/src/executor.rs 82.14% 5 Missing :warning:
src/wasm-lib/kcl/src/ast/types.rs 76.47% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2795 +/- ## ========================================== - Coverage 86.39% 86.38% -0.01% ========================================== Files 61 61 Lines 23579 23609 +30 ========================================== + Hits 20370 20395 +25 - Misses 3209 3214 +5 ``` | [Flag](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2795/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | Coverage Δ | | |---|---|---| | [wasm-lib](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2795/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | `86.38% <80.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.