search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
273 stars 18 forks source link

Fix diagnostic fighting between wasm and typescript (closes #2755) #2799

Closed paultag closed 5 days ago

paultag commented 5 days ago

This is the first PR to stabilize, but we're going to need a followup here for a larger gut of the typescript end of this, and I need to ensure we get tests passing / happy, and the LSP server happy.

qa-wolf[bot] commented 5 days ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jun 26, 2024 2:11am
codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.40%. Comparing base (8fe2d33) to head (ae75351). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2799 +/- ## ========================================== + Coverage 86.38% 86.40% +0.02% ========================================== Files 61 61 Lines 23609 23669 +60 ========================================== + Hits 20395 20452 +57 - Misses 3214 3217 +3 ``` | [Flag](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2799/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | Coverage Δ | | |---|---|---| | [wasm-lib](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2799/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | `86.40% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Irev-Dev commented 5 days ago

Could be related to #2769 I only say that because of the escape $ thing and suddenly we added a lot of $ to kcl samples.

image

Irev-Dev commented 5 days ago

I can't really see uses of $ in the snapshot tests, so not sure.

paultag commented 5 days ago

@Irev-Dev I think it's related to the retry failed tests thing that Lee just landed; I think the upload is wonky and short-cutting the build; watching MacOS now