KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
411 stars 35 forks source link

Undo and redo should work with sketches #2803

Open jtran opened 4 months ago

jtran commented 4 months ago

Undo using Control/Command+Z works when editing code. But when creating a sketch or editing a sketch visually, the same shortcut has no effect. Similarly with redo.

I generally expect undo and redo to work regardless of whether I made the change in code or visually with a sketch.

jessfraz commented 4 months ago

I fixed this in my branch w annotations for history when we update the code.

jessfraz commented 4 months ago

well its part of the problem it wont actually re-execute the code but it will fix it haha

jessfraz commented 4 months ago

added some playwright tests here it works great to undo extrude since not in sketch mode, but in sketch mode it will fix the code but it doesnt trigger the ui updates https://github.com/KittyCAD/modeling-app/issues/2803