search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
366 stars 29 forks source link

codemirror lsp highlighter #2806

Closed jessfraz closed 3 months ago

jessfraz commented 3 months ago

fixes #2796 fixes #2214 fixes #2688 the code portion of #2803, we dont fix the sketch side tho closes #2217 (has a playwright test)

as a follow up to this i can make the colors of the highlighting pop more

qa-wolf[bot] commented 3 months ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jun 29, 2024 11:53pm
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.79%. Comparing base (bb9d24f) to head (e23eabf). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2806 +/- ## ========================================== + Coverage 86.75% 86.79% +0.04% ========================================== Files 62 62 Lines 24565 24610 +45 ========================================== + Hits 21311 21361 +50 + Misses 3254 3249 -5 ``` | [Flag](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2806/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | Coverage Δ | | |---|---|---| | [wasm-lib](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2806/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | `86.79% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.