KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
273 stars 18 forks source link

more expressive semantic tokens #2814

Closed jessfraz closed 5 days ago

qa-wolf[bot] commented 5 days ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jun 26, 2024 10:30am
codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 95.32374% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.05%. Comparing base (47e8d3f) to head (bf1259a). Report is 1 commits behind head on main.

Files Patch % Lines
src/wasm-lib/kcl/src/lsp/kcl/mod.rs 89.89% 10 Missing :warning:
src/wasm-lib/kcl/src/lsp/tests.rs 98.06% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2814 +/- ## ========================================== + Coverage 86.40% 87.05% +0.64% ========================================== Files 61 61 Lines 23669 24639 +970 ========================================== + Hits 20452 21449 +997 + Misses 3217 3190 -27 ``` | [Flag](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2814/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | Coverage Δ | | |---|---|---| | [wasm-lib](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | `87.05% <95.32%> (+0.64%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.