search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
273 stars 18 forks source link

Add setting to toggle scale grid visibility #2838

Open franknoirot opened 3 days ago

franknoirot commented 3 days ago

Closes #2835

Demo

https://github.com/KittyCAD/modeling-app/assets/23481541/254e2909-b886-4a60-ac8a-a40863cfc70a

qa-wolf[bot] commented 3 days ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jul 1, 2024 2:32pm
codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.80%. Comparing base (bb9d24f) to head (8347dd6). Report is 15 commits behind head on main.

:exclamation: Current head 8347dd6 differs from pull request most recent head 5eb1b97

Please upload reports for the commit 5eb1b97 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2838 +/- ## ========================================== + Coverage 86.75% 86.80% +0.04% ========================================== Files 62 62 Lines 24565 24615 +50 ========================================== + Hits 21311 21366 +55 + Misses 3254 3249 -5 ``` | [Flag](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2838/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | Coverage Δ | | |---|---|---| | [wasm-lib](https://app.codecov.io/gh/KittyCAD/modeling-app/pull/2838/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD) | `86.80% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KittyCAD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jessfraz commented 18 hours ago

playwirght test w snapshots :) jsut wanna make sure we dont break it but we know mike will tell us lol