search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
282 stars 20 forks source link

Syntax highlighting is slow #2925

Closed Irev-Dev closed 14 hours ago

Irev-Dev commented 3 days ago

Could my deferred theory have merit Jess?

https://github.com/KittyCAD/modeling-app/assets/29681384/f4d1ce17-a18a-4866-9b10-eb6bac1b7489

jessfraz commented 3 days ago

Could be but more likely just semantic tokens takes a bit

jessfraz commented 3 days ago

I don’t think we’d want to remove the deferrer honestly or else shit would get super backed up

Irev-Dev commented 2 days ago

Okay,

why does the current syntax highlight have to disappear when there's an edit?

jessfraz commented 2 days ago

This will be fixed when we go back to a codemirror lexer

jessfraz commented 2 days ago

It’s the decorators

Irev-Dev commented 14 hours ago

If it'll get closed out for free with something else. I'm thinking we might as well close now instead of trying to track down later.