KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
354 stars 29 forks source link

[FEATURE]: Open Modeling App after update #3018

Open r-barton opened 1 month ago

r-barton commented 1 month ago

[On Windows] The modeling app does not open after installing the latest update. I think for a good UX, the modeling app was already opened, we should provide an option to the user at the end of the installer to open the latest installed version. Currently the installer just exits with no option to open the app.

jessfraz commented 1 month ago

this is def on the tauri side

jessfraz commented 1 month ago

also windows specific on macos this works

jessfraz commented 1 month ago

@pierremtb was sayign this works now, @r-barton can you confirm

r-barton commented 1 month ago

Did not work on my machine when updating the app. I started from v0.24.2 of the modeling app. Screen recording attached. If I run the installer as a fresh install I do get the option to open the app after installation is complete

https://github.com/user-attachments/assets/5bbc6e26-93a1-4449-80cb-cd5f96dbbfe4

r-barton commented 1 month ago

So I think this issue is partially solved

jessfraz commented 1 month ago

yes i always got that too and its not working on upgrade for me, will follow up after next release to see if fixed making sure it wasnt just me

pierremtb commented 1 month ago

Sorry for the confusion, this should get fixed as part of https://github.com/KittyCAD/modeling-app/pull/2815 as we're bumping a few tauri dependencies. But hasn't landed on main or in releases yet!

pierremtb commented 1 month ago

Stumbled on it while looking for something else: the feature was added upstream 2 weeks ago with https://github.com/tauri-apps/plugins-workspace/pull/1498

jessfraz commented 2 weeks ago

we should test this works with electron after the first release

pierremtb commented 2 weeks ago

https://github.com/KittyCAD/modeling-app/pull/3600#issuecomment-2307704325

Confirmed both Windows (Squirrel) and macOS (.app.zip) auto restart after update