search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
412 stars 35 forks source link

Error tooltip missing CSS #3170

Closed ZooSpiritWolf closed 3 months ago

ZooSpiritWolf commented 3 months ago

🐛 on Dev

Steps to reproduce:

  1. Login
  2. Fill editor with malformed KCL code
  3. hover over error marker Expected: Error tooltip with CSS (red border left) Actual: Tooltip missing CSS Video: https://www.loom.com/share/99f2dabb74974b82aa56b3cedf1df2d3?sid=97262649-438b-488e-83b7-bbe04b7f6fce (https://www.loom.com/share/99f2dabb74974b82aa56b3cedf1df2d3?sid=97262649-438b-488e-83b7-bbe04b7f6fce)

Bug report: https://app.qawolf.com/zoo/bug-reports/5ac1f200-0783-4dcc-9174-b1a76ed2bf46

Affected workflows: • Enter KCL Expressions - https://app.qawolf.com/zoo/workflows/clwdt12av00ix11xbfij6ikrq

If you are aware of this bug you can set the priority to low which will prevent it from causing a run failure.

jessfraz commented 3 months ago

not really that bad a regression but when we made tool tips selectable they lost some style

jessfraz commented 3 months ago

https://github.com/KittyCAD/modeling-app/pull/3149

jackdelamotte commented 3 months ago

Ack! Sorry!

jessfraz commented 3 months ago

oh. no worries i didnt notice either!

jackdelamotte commented 3 months ago

Just to confirm before I go down a rabbit hole, no other commits were made today that would have impacted tooltip styling, right? I'm back on my local feature branch from yesterday and I still see the red bar as well as the red squiggles but I'm not seeing those on a fresh pull from main now

feature branch:

image

main:

image
jessfraz commented 3 months ago

oh weird, maybe... cc @franknoirot

jessfraz commented 3 months ago

oh I know what it is, its not you... i can fix

jackdelamotte commented 3 months ago

Oh yay! Awesome

jessfraz commented 3 months ago

sorry about that!

jackdelamotte commented 3 months ago

nw!