Closed jessfraz closed 1 week ago
Currently, clicking these buttons in the file pane UI immediately creates a new file or folder with the name "Untitled" and an index suffix, then sets that new item to be in "renaming mode" so you can immediately set its name.
Instead, we should follow the example of VS Code. Clicking those buttons opens a UI form to set its name, and if you submit this form the file or folder is then created. If you cancel with Esc or by blurring focus on the input no file system access occurs.
This should include an Electron E2E test or Vitest component test of the behavior.
Jordan made the following comments
right click on KCL file window only accepts a click ontop of the shortcut, additionally right click window doesn’t dissapear upon part deletion
https://github.com/user-attachments/assets/28b18672-ef78-4b3c-b3c5-f382be6b9ed8
renaming should auto close the right click window.. doesnt feel right
https://github.com/user-attachments/assets/b7f364d0-aaf0-4f0f-aa4d-dd332e652022
@jessfraz's suggestion is instead of fixing individually is to just follow vcode patterns for the file pane.
Ok these two were fixed by someone at one point (probably during the tauri transition):
I'll fix up the create file / directory to match vs code
video attached
but dont create the file/folder by default, instead wait until they input something
otherwise you just have more clicks to delete this file you didnt want
https://github.com/user-attachments/assets/85d2e582-a7e1-4eaf-b685-4908e655783f