KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
411 stars 35 forks source link

create a regression test for when engine returns an error to the websocket on export #3255

Closed jessfraz closed 2 months ago

jessfraz commented 3 months ago

as a part of fixing https://github.com/KittyCAD/modeling-app/issues/3203

I had to use a branch of engine that sent an error on every export websocket command: https://github.com/KittyCAD/engine/tree/jess/engine-fail-every-export-for-testing

we likely want websocket mocks to trigger this from javascript tests

will leave that to someone else, but hopefully this gets done before we break it again, le sigh

pr that had fix: https://github.com/KittyCAD/modeling-app/pull/3256

Irev-Dev commented 2 months ago

Options from what I can tell

msw is probably the best option.