KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
411 stars 35 forks source link

double click to open files from explorer/ app.exe path/to/kcl/file/or/dir should open in app #3577

Closed jessfraz closed 2 months ago

jessfraz commented 2 months ago

there are a bunch of tests here for various weird shit https://github.com/KittyCAD/modeling-app/blob/main/src/wasm-lib/kcl/src/settings/types/file.rs#L539

like app.exe . should open the curdir

jessfraz commented 2 months ago

more data https://github.com/microsoft/vscode/blob/main/src/main.js#L543

jessfraz commented 2 months ago

windows uses process.argv

Irev-Dev commented 2 months ago

What are you thinking for how to do these tests? Bash scripts kinda thing?

jessfraz commented 2 months ago

No manual but right now this doesn’t work

jessfraz commented 2 months ago

Which is the issue

jessfraz commented 2 months ago

And people use this feature now so we can’t skip it

jessfraz commented 2 months ago

Like I don’t think lee hooked it up at all

jessfraz commented 2 months ago

ill take this one since i know all the weird bits from tauri

Irev-Dev commented 2 months ago

Oh sorry I just assumed test, cool sounds good.