KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
411 stars 35 forks source link

add xstate tests for file manager/some way of testing the stuff that should happen on disk is actually happening versus relying on just file pane #3587

Closed jessfraz closed 2 months ago

jessfraz commented 2 months ago

comment here: https://github.com/KittyCAD/modeling-app/pull/3584#issuecomment-2300290754

Irev-Dev commented 2 months ago

I just sent Farzad a quick message about this, just in case he thinks it's worth waiting until after the v5 migration is done. We'll see what he says.

Irev-Dev commented 2 months ago

He thinks with how close we are to the migration it's worth waiting. @jessfraz do you mind if this is done post electron?

Irev-Dev commented 2 months ago

Oh when the tests are running you can still just run normal node fs stuff, so we can do electron tests in the pane, and back it up by verifying that the file is created?