search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
411 stars 35 forks source link

Phantom panes still open when all panes are closed #3779

Closed Irev-Dev closed 1 month ago

Irev-Dev commented 1 month ago

https://github.com/user-attachments/assets/5d2e09f2-7891-445e-b503-fa8c2c49d28c

Steps to reproduce

  1. close panes
  2. move mouse to where resizer was before panes were close
  3. see it's still there.
jessfraz commented 1 month ago

spooky

franknoirot commented 1 month ago

This is probably where to start investigating https://github.com/KittyCAD/modeling-app/blob/main/src/components/ModelingSidebar/ModelingSidebar.tsx#L207-L224

franknoirot commented 1 month ago

Is this Mac-specific maybe, or v0.25.0-specific? I can't seem to replicate with v0.25.1. Maybe I'll try to find the binary from the v0.25.0 PR and try it there

franknoirot commented 1 month ago

I think this may be a malformed openPanes sort of thing, as I'm not able to reproduce with the v0.25.0 test release binary on MacOS. Would you mind seeing what that stored value is in your app if you're still experiencing this @Irev-Dev? I'll try to reproduce by butchering my openPanes

franknoirot commented 1 month ago

Got it! If the Show debug panel setting is set to off while the pane is open, a phantom pane will appear. I've confirmed this in the web on main, so I'll write a web playwright test for it.