search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
367 stars 30 forks source link

Navigating to a file with parser errors will not update the stream, making it feel like no navigation happened #3803

Open jessfraz opened 3 weeks ago

jessfraz commented 3 weeks ago

i thought there was a test for this???

https://github.com/user-attachments/assets/b4e43c26-7c34-4bd3-befb-fc9cc5bbe9a0

jessfraz commented 3 weeks ago

from @Irev-Dev "I think maybe the generated code has a error in it, I can replicate it not responding to clicks with the following code"

but i still think if this does happen even tho the model shouldnt give us erroredd code we should still open the file... def still a bug

jessfraz commented 3 weeks ago

so perhaps the bug is files don't open if code has bugs which i also thought we had a test for...?

jessfraz commented 3 weeks ago

greg is also going to start intentionally giving us the failed kcl versus good kcl if its that or nothing, so like copilot you can fix it yourself, so like we def need to support this

Irev-Dev commented 3 weeks ago

https://github.com/user-attachments/assets/b450910b-6e8c-4862-a896-9fc100baa287

i.e. how this got through with our tests.

jessfraz commented 3 weeks ago

oh gotcha that makes sense

franknoirot commented 2 weeks ago

Nice, thank you for your debugging @Irev-Dev, I'm able to easily reproduce that issue with a minimal example here: gh-3803.zip

franknoirot commented 2 weeks ago

Working on the text-to-cad issues currently, so unassigning myself for now