KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
417 stars 35 forks source link

renaming SketchGroup/ExtrudeGroup / consistent naming #3906

Closed jessfraz closed 1 month ago

jessfraz commented 1 month ago

The names SketchGroup and ExtrudeGroup were passed down from the original JS parser. I think they are confusing and they leak into the docs, etc externally. I think its confusing because to me a "group" implies more than one and ive seen others misstep on this as well. Idk where the "group" nomenclature comes from but these are singular things, and it gets weirder when you have a "vec" or extrude groups. It should be something singular. Also some things arent extruded like loft, revolve etc.

I propose we rename them, opening for ideas: but what about just "Sketch" and "Solid3d" stealing the latter from the engine, I didn't think we should steal "Solid2d" from engine but I am open to it, just to me that implies it must be closed and I think "Sketch" resonates more with MEs.

Overall goals with naming should be:

the latter two I added because if we are all using the same terms everywhere we will be less confused and new folks starting will have a consistent set of names to talk about the same things.

adamchalmers commented 1 month ago

How about just "sketch" and "solid" for the 2d and 3d shapes? I'm very happy to use Solid3d instead of Solid, I just think it's strange that there's no solid2d to match.

jessfraz commented 1 month ago

ya i like that!