search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
364 stars 29 forks source link

token.txt with device token is not actually persisting #3957

Open jessfraz opened 4 days ago

jessfraz commented 4 days ago

see convo here https://kittycadworkspace.slack.com/archives/C04KFV6NKL0/p1727119529732509

device tokens on the backend never expire so this must be some frontend voodoo, but adding @iterion to confirm im not hallucinating about the backend

jessfraz commented 4 days ago

adding kurt since he touched the file last @Irev-Dev

Irev-Dev commented 4 days ago

Thanks!

jessfraz commented 3 days ago

on the backend these do expire in 14 days, we are fixing but i dont think its that, its more frequent than 14 days for me, @JordanNoone to confirm

JordanNoone commented 3 days ago

I can log when it happens to be so I can confirm, but 14 days seems plausible

iterion commented 3 days ago

If this happens and we think it's less than 14 days we can easily verify in the database. If someone wants to let me know when it does I can check quickly and we can potentially rule out the database side.

I spot checked a few of us and prod and nobody had multiple device access tokens, but it could easily just be beyond expiry now.

iterion commented 3 days ago

OK, for one sessions and device access tokens were only set to last 7 days. I updated sessions to last 14 and device access tokens to last 30 days. So, if we do have a problem on the app side it should become very apparent with much longer lasting tokens.

https://github.com/KittyCAD/common/pull/1084

For tokens with longer expirations you'll need to sign in once more after this ships.