KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
281 stars 20 forks source link

Xstate migration clean up #817

Open Irev-Dev opened 8 months ago

Irev-Dev commented 8 months ago

Clean up items from https://github.com/KittyCAD/modeling-app/pull/713 Related to #228

Irev-Dev commented 8 months ago

clean up toolbar.tsx ..., revert the reversion ... and finish constraints ... bullet points completed by. #865

franknoirot commented 6 months ago

It's possible the constraints could be condensed into a single add constraint event that has different data instead of unique event per constraint, decide if this should change or not.

One thing I will say about this is that I'm not sure how the command bar will know about different commands if there aren't distinct events on the state machine for them. We'd end up having to add logic to support splitting out what kind of constraint you want to apply. I don't think it would be beneficial other than visually tidying up the XState diagram

Irev-Dev commented 6 months ago

I think the main thing is it's a better plugin architecture, but it probably makes sense to get the app working how we want it and then figure out how things might need to be refactored for that, and it's really not a priority anyway.