KittyKatt / screenFetch

Fetches system/theme information in terminal for Linux desktop screenshots.
GNU General Public License v3.0
3.84k stars 454 forks source link

KWin code incorrectly references openbox. #2

Closed ghost closed 13 years ago

ghost commented 13 years ago

In fact this dumps a awk error if you happen to use kwin. Below patch seems to do the job.

From 419cd0999774944192497ab84cdc6bd6067df47c Mon Sep 17 00:00:00 2001 From: Adam Young atyrelyoung@gmail.com Date: Thu, 21 Apr 2011 02:08:10 -0700 Subject: [PATCH] KWin parsing incorrectly references openbox.


screenfetch-dev | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/screenfetch-dev b/screenfetch-dev index 7490c7e..6f9f4cc 100755 --- a/screenfetch-dev +++ b/screenfetch-dev @@ -352,7 +352,7 @@ detectwmtheme () { 'Metacity') if [ "gconftool-2 -g /apps/metacity/general/theme" ]; then Win_theme="$(gconftool-2 -g /apps/metacity/general/theme)"; fi ;; 'Xfwm4') if [ -f ${XDG_CONFIG_HOME:-${HOME}/.config}/xfce4/xfconf/xfce-perchannel-xml/xfwm4.xml ]; then Win_theme="$(xfconf-query -c xfwm4 -p /general/theme)"; fi;; 'IceWM') if [ -f $HOME/.icewm/theme ]; then Win_theme="$(awk -F"[\",/]" '!/#/ {print $2}' $HOME/.icewm/theme)"; fi;;

ghost commented 13 years ago

I forgot just how bad the markdown is here, I'll e-mail the patches just in case.

Kwpolska commented 13 years ago

Don't do that, just fork the repo, add it and make a pull request. Wouldn't you mind doing it for yourself?

ghost commented 13 years ago

Sure thing

On Apr 21, 2011, at 3:39 AM, Kwpolska reply@reply.github.com wrote:

Don't do that, just fork the repo, add it and make a pull request. Wouldn't you mind doing it for yourself?

Reply to this email directly or view it on GitHub: https://github.com/KittyKatt/screenFetch/issues/2#comment_1038688

Kwpolska commented 13 years ago

I added your patches, they're waiting to be pulled.

Cheers, -- Kwpolska (http://kwpolska.co.cc) O< ascii ribbon campaign - stop html mail - www.asciiribbon.org