search

KittyKatt / screenFetch

Fetches system/theme information in terminal for Linux desktop screenshots.
GNU General Public License v3.0
3.85k stars 454 forks source link

Wrong system information in macOS #615

Closed ivan-avalos closed 5 years ago

ivan-avalos commented 5 years ago 
[x] bug report
[ ] new distro request

Bug report

How it should be:

macOS = platform.
Darwin = operating system.
XNU = kernel.

Current situation:

macOS = operating system.
Darwin = kernel.
XNU = ???

Output

                 -/+:.          xxxx@xxxx
                :++++.          OS: 64bit Mac OS X 10.14.3 18D109
               /+++/.           Kernel: x86_64 Darwin 18.2.0
       .:-::- .+/:-``.::-       Uptime: 3d 6h 11m
    .:/++++++/::::/++++++/:`    Packages: 412
  .:///////////////////////:`   Shell: bash 3.2.57
  ////////////////////////`     Resolution: 1440x900
 -+++++++++++++++++++++++`      DE: Aqua
 /++++++++++++++++++++++/       WM: Quartz Compositor
 /sssssssssssssssssssssss.      WM Theme: Blue
 :ssssssssssssssssssssssss-     Font: SFMono-Regular
  osssssssssssssssssssssssso/`  CPU: Intel Core i5-5350U @ 1.80GHz
  `syyyyyyyyyyyyyyyyyyyyyyyy+`  GPU: Intel HD Graphics 6000 
   `ossssssssssssssssssssss/    RAM: 3820MiB / 8192MiB
     :ooooooooooooooooooo+.    
      `:+oo+/:-..-:/+o+/-
darealshinji commented 5 years ago

I guess Mac OS X should be changed to macOS anyway. XNU as kernel name makes sense. But there is no "platform" line in screenFetches output. What exactly does uname -o and uname -s print?

ivan-avalos commented 5 years ago

Yeah, there's no platform line, but you can't put macOS as the operating system because the actual operating system is called Darwin. It doesn't make sense to consider macOS as an operating system, even though Apple wants people to call it that way. Also, uname -s prints Darwin. uname -o prints an error.

Darwin = operating system.
XNU = kernel.
darealshinji commented 5 years ago

For me it says OS is Ubuntu which is not the actual OS name either, GNU/Linux would be correct. On the other side, saying that my OS name is Ubuntu isn't completely wrong. I don't know if I really want to change that. You could of course separate it into OS and distro. In my case I would get Distro: Ubuntu, OS: GNU/Linux and Kernel: Linux, for you it would be Distro: macOS, OS: Darwin and Kernel: XNU. For most other OSes you would ommit the distro entry.

ivan-avalos commented 5 years ago

Well, that would be a better idea, separating both different things.

ivan-avalos commented 5 years ago

Now I think this is irrelevant.