KittyKatt / screenFetch

Fetches system/theme information in terminal for Linux desktop screenshots.
GNU General Public License v3.0
3.88k stars 455 forks source link

GTK3 theme not detected properly (Openbox) #639

Closed dglava closed 5 years ago

dglava commented 5 years ago

I'm submitting a ...

[X] bug report
[ ] new distro request

Bug report

screenfetch -v
:: Finding distro...found as 'Arch Linux '
:: Finding hostname and user...found as 'dino@masina-l'
:: Finding kernel version...found as 'x86_64 Linux 5.3.1-arch1-1-ARCH'
:: Finding current uptime...found as '55m'
:: Finding current package count...found as '742'
:: Finding current shell...found as 'bash 5.0.9'
:: Finding current resolution(s)...found as '1280x800'
:: Finding desktop environment...found as 'Not Present'
:: Finding window manager...found as 'OpenBox'
:: Finding window manager theme...found as 'Numix-mod'
:: Finding GTK2 theme...found as 'Zukitre'
:: Finding GTK3 theme...found as 'Adwaita'
:: Finding icon theme...found as 'Faenza-Dark'
:: Finding user font...found as 'DejaVu Sans 10'
:: Finding current CPU...found as 'Intel Core i5 M 520 @ 4x 2.399GHz'
:: Finding current disk usage...found as '133G / 226G (62%%)'
:: Finding current GPU...found as 'Not Found'
:: Finding current RAM usage...found as '1067MiB / 3735MiB'
                   -`                 
                  .o+`                 dino@masina-l
                 `ooo/                 OS: Arch Linux 
                `+oooo:                Kernel: x86_64 Linux 5.3.1-arch1-1-ARCH
               `+oooooo:               Uptime: 55m
               -+oooooo+:              Packages: 742
             `/:-:++oooo+:             Shell: bash 5.0.9
            `/++++/+++++++:            Resolution: 1280x800
           `/++++++++++++++:           WM: OpenBox
          `/+++ooooooooooooo/`         WM Theme: Numix-mod
         ./ooosssso++osssssso+`        GTK Theme: Zukitre [GTK2], Adwaita [GTK3]
        .oossssso-````/ossssss+`       Icon Theme: Faenza-Dark
       -osssssso.      :ssssssso.      Font: DejaVu Sans 10
      :osssssss/        osssso+++.     Disk: 133G / 226G (62%)
     /ossssssss/        +ssssooo/-     CPU: Intel Core i5 M 520 @ 4x 2.399GHz
   `/ossssso+/:-        -:/+osssso+-   GPU: Intel Corporation Core Processor Integrated Graphics Controller (rev 02)
  `+sso+:-`                 `.-/+oso:  RAM: 1067MiB / 3735MiB
 `++:.                           `-/+/
 .`                                 `/

My GTK3 theme is also Zukitre. I think the problem lies in the "Proper gtk3 theme detection" part https://github.com/KittyKatt/screenFetch/blob/83f641b2160eed1d91c95a7980c2351c57e0cc92/screenfetch-dev#L2802-L2806

When using Openbox standalone, the value in gsettings doesn't get set for the theme. The "Experimental gtk3 theme detection" works reliably on Openbox.

KittyKatt commented 5 years ago

@dglava Could you try to reclone master? The above commit fixed it in my OpenBox Arch VM.

dglava commented 5 years ago

It works. The GTK3 theme is now properly detected when setting the GTK3 theme with LXappearance (without setting the dconf/gsettings key).

KittyKatt commented 5 years ago

Perfect. Thanks for reporting!