Kittyfisto / Tailviewer

Open source log file viewer
https://kittyfisto.github.io/Tailviewer/
MIT License
199 stars 37 forks source link

Fixed bug where TV would display a non-empty log file as empty #273 #274

Closed Kittyfisto closed 3 years ago

Kittyfisto commented 3 years ago

Fixes #273

Changes proposed in this pull request:

Any expected problems concerning backwards compatibility of existing plugins?
No

Any expected problems concerning backwards compatibility of existing user settings?
No

Does this break existing user workflows?
Potentially: Users which so far have relied on having timestamps more than 200 characters from the start will no longer be able to properly merge their log files by timestamp. However I don't expect that there are any text log files where the timestamp is so far to the right. Either it's in the first 50 characters or the log file doesn't have a timestamp.

Furthermore, users which have relied on ASCII characters [0-32] other than space or tab and 127 (DEL) to be printed as space will no longer be able to do so and will instead have to print a proper space or tab character. Likewise I expect the impact of this to be non-existant as it's highly unusualy to print '\0' or some other character where a space would have been appropriate.