Closed Kittyfisto closed 3 years ago
Fixes #200
ILogFile continues to have properties (as in C# properties) which shouldn't be modeled as such and instead be an ILogFIlePropertyDescriptor:
ILogFIlePropertyDescriptor
Yes - Any plugin implementing ILogFile
ILogFile.MaxCharactersPerLine
TextLogFileProperties.MaxCharactersInLine
ILogFile.EndOfSourceReached
ILogFile.Count
LogFileProperties.LogEntryCount
ILogFile.GetValue
GetProperty
ILogFile.GetAllValues
GetAllProperties
No
Fixes #200
Reason for this change
ILogFile continues to have properties (as in C# properties) which shouldn't be modeled as such and instead be an
ILogFIlePropertyDescriptor
:Any expected problems concerning backwards compatibility of existing plugins?
Yes - Any plugin implementing ILogFile
Changed Types
ILogFile.MaxCharactersPerLine
and replaced it withTextLogFileProperties.MaxCharactersInLine
ILogFile.EndOfSourceReached
- It was only used for tests and never should have been part of the public interface to begin withILogFile.Count
and replaced with withLogFileProperties.LogEntryCount
ILogFile.GetValue
toGetProperty
along with its overloaded extension methodsILogFile.GetAllValues
toGetAllProperties
Any expected problems concerning backwards compatibility of existing user settings?
No
Does this break existing user workflows?
No