fix: make byteArray return empty array on failure instead of fatal error

[Andrew-Lees11]

Description

This PR changes byteArray so that on failure it returns an empty array instead of throwing a fatal error.

Motivation and Context

This is required because you make pass user code into the function (such as in Kitura-Session where a users Cookie is decoded). If it throws a fatal error on failure then a user can crash the system. If it returns an empty array the application can handle this in the correct way.

How Has This Been Tested?

This has been tested within Kitura-Session. Using this code makes the session reject the cookie instead of throwing a fatal error and crashing the server.

Checklist:

• [x] I have submitted a CLA form
• [x] If applicable, I have updated the documentation accordingly.

[ianpartridge]

Looks good to me 🙂 Would be nice to have a test.

[billabt]

I understand the rationale behind the PR but I just want make sure you know that it’s a potential source breaking change. The unexpected empty array could cause problems that could be difficult to detect and find. Have you considered this? @ianpartridge, you ok with this?

[ianpartridge]

Yeah I think we should make this change, the current behaviour is dangerous.

[Andrew-Lees11]

So the only way this impacts existing applications is that if it was previously throwing a fatal error. This makes it unlikely that this will change expected behavior. In the next major release of BlueCryptor this function should probably throw but I think this fix will solve the current issue in a non breaking way.