Closed rob-deans closed 7 years ago
@rob-deans - Thanks for the PR! Can you make the following changes before we can merge this PR?
-[![Build Status](https://travis-ci.org/IBM-Swift/CloudConfiguration.svg?branch=develop)](https://travis-ci.org/IBM-Swift/CloudConfiguration)
Can you update config_example.json
so that it has so made up values for password, url, username, etc.? For instance, for username, you could use natural-language-username
… something along those lines that self-descriptive.
Can you update FileLoadTests.swift
so the tests are more meaningful? Instead of just checking that the length of username, password, etc., is greater than 0, let’s make sure that the values returned from the service match the expected values. For instance, say you use natural-language-username
as the username in the config_example.json
file, then let’s add an assertion to FileLoadTests.swift
that ensures this is the case.
Codecov Report
76.51% <83.33%> (?)
65.93% <71.42%> (ø)
79.67% <88.23%> (ø)
Continue to review full report at Codecov.