search

Kitura / CloudEnvironment

Convenience Swift package for accessing environment variables, credentials.
Apache License 2.0
12 stars 16 forks source link

remove logger from package.swift #45

Closed Andrew-Lees11 closed 6 years ago

Andrew-Lees11 commented 6 years ago

Description

Logger was brought in by Swift-cfenv and so does not need to be explicitly declared in the package.swift file.

How Has This Been Tested?

Swift test was run and all tests pass. This change should have no impact of code functionality.

codecov-io commented 6 years ago

Codecov Report

Merging #45 into master will decrease coverage by 10.31%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #45       +/-   ##
===========================================
- Coverage   73.78%   63.46%   -10.32%     
===========================================
  Files          17       34       +17     
  Lines         473      969      +496     
  Branches        0      129      +129     
===========================================
+ Hits          349      615      +266     
- Misses        124      278      +154     
- Partials        0       76       +76
Flag Coverage Δ
#CloudEnvironment 63.46% <ø> (-10.32%) :arrow_down:
Impacted Files Coverage Δ
Tests/CloudEnvironmentTests/RedisTests.swift 45% <0%> (ø)
Tests/CloudEnvironmentTests/PostgreSQLTests.swift 40.9% <0%> (ø)
...vironmentTests/NaturalLangUnderstandingTests.swift 60% <0%> (ø)
Tests/CloudEnvironmentTests/PushSDKTests.swift 38.88% <0%> (ø)
Tests/CloudEnvironmentTests/DB2Tests.swift 40.9% <0%> (ø)
...ironmentTests/CloudFunctionsCredentialsTests.swift 47.61% <0%> (ø)
Tests/CloudEnvironmentTests/LocalFileTests.swift 47.05% <0%> (ø)
Tests/CloudEnvironmentTests/CloudantTests.swift 34.78% <0%> (ø)
Tests/CloudEnvironmentTests/MySQLTests.swift 40.9% <0%> (ø)
...sts/CloudEnvironmentTests/ObjectStorageTests.swift 40% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 446c74f...89ef8be. Read the comment docs.