search

Kitura / Kitura-CouchDB

CouchDB adapter for Kitura
Apache License 2.0
51 stars 29 forks source link

Test: Add Completion statement #87

Closed Andrew-Lees11 closed 5 years ago

Andrew-Lees11 commented 5 years ago

Description

Added a completion statement to dropDatabaseIfExists so that if there isn't a database it will still call the next function and continue the tests.

Also changed the default database name in the tests to the suggested local database to help when testing locally.

djones6 commented 5 years ago

@Andrew-Lees11 after talking with @ianpartridge we'd like to disable the tests that are failing (the Kitura-NIO builds) and merge this PR. #91 needs to be investigated and the a PR raised to fix the tests (or to re-enable the tests once Kitura-NIO is fixed).

djones6 commented 5 years ago

@Andrew-Lees11 I may have fixed this in https://github.com/IBM-Swift/Kitura-NIO/pull/116 (which has now been tagged). I've restarted the failing CI.

Edit: we're past that failure, but have uncovered a new one. I've updated #91 accordingly.