search

Kitura / Kitura-CredentialsHTTP

A plugin for the Kitura-Credentials framework that authenticates using HTTP Basic and Digest authentication
Apache License 2.0
16 stars 14 forks source link

Fixes a warning #44

Closed gmosx closed 6 years ago

gmosx commented 6 years ago

Fixes a .characters warning.

codecov-io commented 6 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files           2        2           
  Lines         167      167           
=======================================
  Hits          134      134           
  Misses         33       33
Flag Coverage Δ
#CredentialsHTTP 80.23% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
...ources/CredentialsHTTP/CredentialsHTTPDigest.swift 78.57% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4473713...648da2e. Read the comment docs.

tunniclm commented 6 years ago

IIRC this is a breaking change for Swift 4.0 so we should increment the version appropriately when merged. After a quick check, this does not seem to be the case. My bad,

tunniclm commented 6 years ago

@gmosx Would you mind registering on the CLA tool, then I will merge this now the Travis tests have completed.

gmosx commented 6 years ago

What is the CLA 'tool' ? Link ? Or should I just scan the CLA Form and email it?

gmosx commented 6 years ago

OK I signed it through cla-assistant.io

tunniclm commented 6 years ago

@gmosx Well, I can see you are registered on cla-assistant even though the check on PR doesn't seem to have updated properly (even though I tried to get it to be.) So merging.

tunniclm commented 6 years ago

Thanks for the fix, sorry it took so long to merge!

gmosx commented 6 years ago

Thanks.

ianpartridge commented 6 years ago

@tunniclm are you going to tag 2.0.1?