search

Kitura / Kitura-WebSocket

WebSocket support for Kitura
Apache License 2.0
68 stars 30 forks source link

Switch to KituraNIO if environment variable is set. #68

Closed mamabusi closed 6 years ago

pushkarnk commented 6 years ago

@mamabusi I don't think this switch would work with Kitura-WebSocket for two reasons. Firstly, Kitura-WebSocket uses some KituraNet classes, like IncomingSocketProcessor, that do not have an equivalent in Kitura-NIO. Secondly, it also uses BlueSocket extensively, which is pulled via KituraNet. In the SwiftNIO port of WebSocket, we use NIO's abstractions.

mamabusi commented 6 years ago

Had a discussion with @pushkarnk and @nethraravindran . The switch to KituraNIO would not work here because of missing API of BlueSocket like the IncomingSocketHandler. Closing the PR.

djones6 commented 6 years ago

@pushkarnk @mamabusi So what's the solution here? Could we merge the websocket-nio and master branches together, or potentially cut a special tag of WebSocket which we use in NIO mode?

pushkarnk commented 6 years ago

@djones6 We're trying to have a special tag? However, there's some confusion about using .exact() with a tag that doesn't point to a commit on the master branch. Trying to clear that confusion first.

mamabusi commented 6 years ago

@djones6 We were able to use .exact() with a tag to point NIO mode of Websocket.