Kitura / Kitura-redis

Swift Redis library
Apache License 2.0
94 stars 25 forks source link

Issue 900 #51

Closed quanvo87 closed 7 years ago

quanvo87 commented 7 years ago

Make APIs synchronous and throwing.

Description

Motivation and Context

Eliminate callback hell.

How Has This Been Tested?

Checklist:

codecov-io commented 7 years ago

Codecov Report

Merging #51 into master will decrease coverage by -0.27%. The diff coverage is 85.51%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   86.99%   86.73%   -0.27%     
==========================================
  Files          36       53      +17     
  Lines        6052     9255    +3203     
==========================================
+ Hits         5265     8027    +2762     
- Misses        787     1228     +441
Impacted Files Coverage Δ
Tests/SwiftRedisTests/TestTransactionsPart7.swift 93.77% <ø> (ø) :white_check_mark:
Sources/RedisMulti+List.swift 100% <ø> (ø) :white_check_mark:
Tests/SwiftRedisTests/TestSetCommandsPart2.swift 95.35% <ø> (-0.01%) :x:
Sources/RedisMulti+Geo.swift 100% <100%> (ø)
Sources/Redis+Basic.swift 98.49% <100%> (+5.63%) :white_check_mark:
Sources/Redis+List.swift 100% <100%> (ø) :white_check_mark:
Sources/Redis+Geo.swift 100% <100%> (ø)
Sources/RedisMulti+Hash.swift 96.15% <100%> (+0.91%) :white_check_mark:
Sources/RedisMulti.swift 76.92% <100%> (+3.39%) :white_check_mark:
Sources/RedisInfo.swift 100% <100%> (ø) :white_check_mark:
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update faf5df0...aa4ed77. Read the comment docs.