Kitura / Kitura-redis

Swift Redis library
Apache License 2.0
94 stars 25 forks source link

Clarify usage comment for set() functions #67

Closed mr-j-tree closed 6 years ago

mr-j-tree commented 6 years ago

It was not immediately clear that supplying a value of false for the "exists" argument has a special meaning. It causes the "NX" argument to be sent to Redis, as opposed to no argument when supplying a value of nil. At least that was my experience when using this function for the first time - the implications of true/false/nil were not explained until I read the source code for this function.

Description

Motivation and Context

How Has This Been Tested?

Checklist:

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

ianpartridge commented 6 years ago

Thanks!